[Messenger] Fix BC layer for stamps moved into separate packages #37826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ogizanagi
commented
Aug 13, 2020
ogizanagi
commented
| Q | A |
|---|---|
| Branch? | 5.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #37616 |
| License | MIT |
| Doc PR | N/A |
ogizanagi
commented
Aug 13, 2020
| self::assertSame([ | ||
| DoctrineReceivedStamp::class => [$s1, $s3], | ||
| RedisReceivedStamp::class => [$s2], | ||
| ], $envelope->all()); |
Contributor
Author
There was a problem hiding this comment.
Unfortunately, I think we cannot do much for the case someone calls Envelope::all() with no type argument and still uses the alias instead of the new fqcn to do their things.
Tobion
reviewed
Aug 13, 2020
fabpot
approved these changes
Aug 17, 2020
Member
|
Thank you @ogizanagi. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.