The PHPUnit\Util\XML class has been removed in PHPUnit 9.3 #37778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Aug 9, 2020
Member
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Aug 10, 2020
…ible (derrabus) This PR was merged into the 3.4 branch. Discussion ---------- Made reference to PHPUnit\Util\XML::loadfile php5-compatible | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Fixup of #37778. My code was apparently not php5-friendly. Sorry for that. 😓 Commits ------- 4bf6405 Made reference to PHPUnit\Util\XML::loadfile php5-compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit\Util\XML, an internal PHPUnit class, is used in a couple of tests. Those tests fail on PHPUnit 9.3 because that class has been removed. This PR fixes those tests by using the new class if it's available.If this is too much C&P, we could consider having PhpUnitBridge polyfill this call.