Fix deprecated libxml_disable_entity_loader #37763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
commented
Aug 7, 2020
| $valid = @$dom->schemaValidateSource($source); | ||
| libxml_disable_entity_loader($disableEntities); | ||
| } else { | ||
| $valid = @$dom->schemaValidateSource($source); |
Member
Author
There was a problem hiding this comment.
I'm not sure about this change: in previous code, the entity_loader were enabled, but the flag LIBXML_NOENT is not supported by schemaValidateSource.
Member
Author
There was a problem hiding this comment.
Member
|
This should be fixed on 3.4. |
Member
Author
|
good catch @derrabus . Rebased. |
fabpot
approved these changes
Aug 10, 2020
Member
|
Thank you @jderusse. |
This was referenced Aug 31, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecation
Function libxml_disable_entity_loader() is deprecatedtriggered by php/php-src#5867 in PHP8