[Validator] Add missing translations for german and vietnamese #37761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jschaedl
commented
Aug 7, 2020
jschaedl
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| License | MIT |
jschaedl
commented
Aug 7, 2020
| </trans-unit> | ||
| <trans-unit id="99"> | ||
| <source>This value is not a valid International Securities Identification Number (ISIN).</source> | ||
| <target>Giá trị này không phải là International Securities Identification Number (ISIN).</target> |
Contributor
Author
There was a problem hiding this comment.
@van2412 Can you please have a look? I am not sure how we should translate "International Securities Identification Number". Thank you :-)
Contributor
There was a problem hiding this comment.
I'm a Vietnamese person. I think it should be "Giá trị này không phải là Mã số chứng khoán quốc tế (ISIN).". Anyway, let's wait for your friend's response.
There was a problem hiding this comment.
@seriquynh This looks good to me. But I suggest adding the translation of "valid" as well. Like Giá trị này không phải là mã số chứng khoán quốc tế (ISIN) hợp lệ
Contributor
There was a problem hiding this comment.
I agree with your translation message.
jschaedl
commented
Aug 7, 2020
src/Symfony/Component/Validator/Resources/translations/validators.vi.xlf
Outdated
Show resolved
Hide resolved
van2412
reviewed
Aug 7, 2020
src/Symfony/Component/Validator/Resources/translations/validators.vi.xlf
Outdated
Show resolved
Hide resolved
…ors.vi.xlf Co-authored-by: van2412 <68100098+van2412@users.noreply.github.com>
van2412
approved these changes
Aug 9, 2020
Member
|
Thank you @jschaedl. |
fabpot
added a commit
that referenced
this pull request
Aug 9, 2020
…namese (jschaedl) This PR was squashed before being merged into the 3.4 branch. Discussion ---------- [Validator] Add missing translations for german and vietnamese | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> Commits ------- f4bd34a [Validator] Add missing translations for german and vietnamese
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.