[FrameworkBundle] do not use deprecated mailer.logger_message_listener service #37728
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 3, 2020
xabbuh
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
stof
reviewed
Aug 3, 2020
| $container->getDefinition('mailer.transports')->setArgument(0, $transports); | ||
| $container->getDefinition('mailer.default_transport')->setArgument(0, current($transports)); | ||
|
|
||
| $container->removeDefinition('mailer.logger_message_listener'); |
Member
There was a problem hiding this comment.
why removing a definition and adding a deprecated alias following it ? Why not creating the right deprecated alias from the beginning ?
Member
Author
There was a problem hiding this comment.
The mailer.message_logger_listener service is not always defined (only when the profiler is enabled).
Member
There was a problem hiding this comment.
but here, you still remove the mailer.logger_message_listener definition all the time to replace it by an alias. So I don't see how this matters.
chalasr
approved these changes
Aug 3, 2020
fabpot
approved these changes
Aug 11, 2020
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Aug 21, 2020
…logger listener (xabbuh) This PR was merged into the 5.2-dev branch. Discussion ---------- [FrameworkBundle] properly choose the best mailer message logger listener | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Properly merge the changes from #37729 and #37728. Commits ------- 6cffc79 properly choose the best mailer message logger listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.