[Form] Fix Guess phpdoc return type #37725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Aug 3, 2020
andrew-demb
reviewed
Aug 3, 2020
ogizanagi
approved these changes
Aug 13, 2020
fabpot
approved these changes
Aug 13, 2020
Member
|
Thank you @franmomu. |
This was referenced Aug 31, 2020
Merged
Merged
Merged
franmomu
added a commit
to franmomu/SonataAdminBundle
that referenced
this pull request
Aug 31, 2020
symfony/symfony#37725 was released in 4.4.12
franmomu
added a commit
to franmomu/SonataAdminBundle
that referenced
this pull request
Aug 31, 2020
symfony/symfony#37725 was released in 4.4.12
OskarStark
pushed a commit
to sonata-project/SonataAdminBundle
that referenced
this pull request
Sep 1, 2020
symfony/symfony#37725 was released in 4.4.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Guessis abstract,staticrepresents better the return type, so callingTypeGuess::getBestGuess()would returnTypeGuessinstead ofGuess.