Skip to content

[FrameworkBundle] convert config/serializer.xml to php #37208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tobion merged 2 commits into from
Jun 21, 2020
Merged

[FrameworkBundle] convert config/serializer.xml to php #37208

Tobion merged 2 commits into from
Jun 21, 2020

Conversation

@mamontovdmitriy
Copy link
Contributor

@mamontovdmitriy mamontovdmitriy commented Jun 11, 2020 •
edited by Tobion
Loading

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Part of #37186
License MIT

Hello!

This PR contains a new configuration file serializer.php instead of serializer.xml.

@mamontovdmitriy mamontovdmitriy force-pushed the serializer-php-config branch from 916e5fe to b43f8d8 Compare June 11, 2020 09:58
@nicolas-grekas nicolas-grekas added this to the next milestone Jun 11, 2020
Tobion
Tobion suggested changes Jun 11, 2020
View reviewed changes
@mamontovdmitriy
Copy link
Contributor Author

mamontovdmitriy commented Jun 11, 2020

@Tobion , Thank you! I've corrected it.

@mamontovdmitriy mamontovdmitriy requested a review from Tobion June 11, 2020 14:58
@fabpot
Copy link
Member

fabpot commented Jun 11, 2020

Tests are apparently broken by these changes.

@mamontovdmitriy
Copy link
Contributor Author

mamontovdmitriy commented Jun 11, 2020

Tests are apparently broken by these changes.

My fault :) Should I modify the tests or revert the commit 4696ec2, that includes a fix of the argument of serializer.mapping.class_metadata_factory? How should I ensure compatibility with #37214 ?

@Tobion
Copy link
Contributor

Tobion commented Jun 11, 2020 •
edited
Loading

I've merged ##37214 up to master and fixed the test. Please rebase your PR.

@mamontovdmitriy mamontovdmitriy force-pushed the serializer-php-config branch from cb42fcb to b3d0fd9 Compare June 12, 2020 06:37
@mamontovdmitriy
Copy link
Contributor Author

mamontovdmitriy commented Jun 12, 2020 •
edited
Loading

@Tobion , thank you :) I've rebased my branch. Review please

@rvanlaak rvanlaak mentioned this pull request Jun 12, 2020
Merged
@mamontovdmitriy mamontovdmitriy requested a review from Tobion June 12, 2020 16:33
@Tobion Tobion force-pushed the serializer-php-config branch from b98170c to ad6b433 Compare June 19, 2020 12:56
@Tobion Tobion force-pushed the serializer-php-config branch from ad6b433 to 62e9788 Compare June 21, 2020 15:56
@Tobion
Copy link
Contributor

Tobion commented Jun 21, 2020

Thank you @mamontovdmitriy.

@Tobion Tobion merged commit efbf840 into symfony:master Jun 21, 2020
@nicolas-grekas nicolas-grekas removed this from the next milestone Oct 5, 2020
@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

+1 more reviewer

@Tobion Tobion Tobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

FrameworkBundle Status: Reviewed

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@mamontovdmitriy @fabpot @Tobion @nicolas-grekas @carsonbot