Skip to content

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 8, 2020

Q A
Branch? 5.1
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

The methods will be deprecated in 2.11 (see doctrine/dbal#4019), but the forward compatibility layer is only present in 3.0 (see doctrine/dbal#4007).

@xabbuh xabbuh added this to the 5.1 milestone Jun 8, 2020
@xabbuh xabbuh requested a review from sroze as a code owner June 8, 2020 09:21
@fabpot
Copy link
Member

fabpot commented Jun 8, 2020

Thank you @xabbuh.

@fabpot fabpot merged commit 0b19249 into symfony:5.1 Jun 8, 2020
@xabbuh xabbuh deleted the messenger-dbal-compat branch June 8, 2020 10:44
nicolas-grekas pushed a commit that referenced this pull request Jun 9, 2020
… 2.11+ (xabbuh)

This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger] fix forward compatibility with Doctrine DBAL 2.11+

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

The methods will be deprecated in 2.11 (see doctrine/dbal#4019), but the forward compatibility layer is only present in 3.0 (see doctrine/dbal#4007).

Commits
-------

bca4f99 fix forward compatibility with Doctrine DBAL 2.11+
nicolas-grekas added a commit that referenced this pull request Jun 9, 2020
* 4.4:
  minor #37141 [Messenger] fix forward compatibility with Doctrine DBAL 2.11+ (xabbuh)
  fix forward compatibility with Doctrine DBAL 3
  [WebProfilerBundle] Set NullLogger for functional tests
  [Mailer] Fixed generator bug when creating multiple transports using Transport::fromDsn
  [FrameworkBundle] Fix XSD definition
  Update welcome.html.php
  [travis] add nightly to allowed failures
nicolas-grekas added a commit that referenced this pull request Jun 9, 2020
* 5.0:
  minor #37141 [Messenger] fix forward compatibility with Doctrine DBAL 2.11+ (xabbuh)
  fix forward compatibility with Doctrine DBAL 3
  [WebProfilerBundle] Set NullLogger for functional tests
  [Mailer] Fixed generator bug when creating multiple transports using Transport::fromDsn
  [FrameworkBundle] Fix XSD definition
  Update welcome.html.php
  [travis] add nightly to allowed failures
nicolas-grekas added a commit that referenced this pull request Jun 9, 2020
* 5.1:
  minor #37141 [Messenger] fix forward compatibility with Doctrine DBAL 2.11+ (xabbuh)
  fix forward compatibility with Doctrine DBAL 3
  [WebProfilerBundle] Set NullLogger for functional tests
  [Mailer] Fixed generator bug when creating multiple transports using Transport::fromDsn
  [FrameworkBundle] Fix XSD definition
  Update welcome.html.php
  [FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait
  [travis] add nightly to allowed failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants