Skip to content

[HttpClient] Throw JsonException instead of TransportException on empty response in Response::toArray() #37065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 1 commit into from
Jun 3, 2020
Merged

[HttpClient] Throw JsonException instead of TransportException on empty response in Response::toArray() #37065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpClient/Response/ResponseTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public function getContent(bool $throw = true): string
public function toArray(bool $throw = true): array
{
if ('' === $content = $this->getContent($throw)) {
throw new TransportException('Response body is empty.');
throw new JsonException('Response body is empty.');
}

if (null !== $this->jsonData) {
Expand Down
6 changes: 6 additions & 0 deletions src/Symfony/Component/HttpClient/Tests/Response/MockResponseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ public function testToArrayError($content, $responseHeaders, $message)

public function toArrayErrors()
{
yield [
'content' => '',
'responseHeaders' => [],
'message' => 'Response body is empty.',
];

yield [
'content' => '{}',
'responseHeaders' => ['content-type' => 'plain/text'],
Expand Down