[Validator] use "allowedVariables" to configure the ExpressionLanguageSyntax constraint #37009
Conversation
xabbuh
commented
May 30, 2020
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 5.1 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix symfony/symfony-docs#13669 |
| License | MIT |
| Doc PR |
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Makes sense to me. Just a naming suggestion.
| public $service; | ||
| public $validateNames = true; | ||
| public $names = []; | ||
| public $variableNames = []; |
There was a problem hiding this comment.
$allowedVariables would be better to me (as suggested in the linked doc issue btw)
There was a problem hiding this comment.
oh, and shouldn't the default be null, to allow any variables?
There was a problem hiding this comment.
Indeed, the suggested name sounds better to me. I am going to change that.
My reasoning for the empty array as the default value was that allowing arbitrary names rather looks like an edge case to me.
There was a problem hiding this comment.
Not allowing any variables by default means allowing only static expressions, isn't it? Since static expressions are never why ppl use EL, this would effectively force ppl to be explicit all the time.
There was a problem hiding this comment.
I applied the suggested changes while merging, please tell if you think this is a mistake :)
javiereguiluz
left a comment
javiereguiluz
left a comment
There was a problem hiding this comment.
Thanks for this contribution! I agree with Nico's comments, but overall it looks OK.
…eSyntax constraint
nicolas-grekas
changed the title
|
Thank you @xabbuh. |
4 participants
