[HttpKernel] Prevent calling method_exists() with non-string values #36901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
May 22, 2020
yceruto
approved these changes
May 22, 2020
chalasr
approved these changes
May 22, 2020
fabpot
approved these changes
May 22, 2020
Member
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
May 24, 2020
This PR was merged into the 5.1 branch. Discussion ---------- Don't call method_exists() with non-objects. | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A Followup to #36901. Commits ------- 9efb442 Don't call method_exists() with non-objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On php 8,
method_exists()will raise aTypeErrorif the first argument is neither an object or string. We do have a test case that calls theControllerResolverwith integer1as$controller. This test should work as expected again on php 8.