Skip to content

[Validator] Make ExpressionLanguageSyntax validator usable with annotation #36886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
May 22, 2020
Merged

[Validator] Make ExpressionLanguageSyntax validator usable with annotation #36886

fabpot merged 1 commit into from
May 22, 2020

Conversation

@jderusse
Copy link
Member

@jderusse jderusse commented May 20, 2020

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets NA
License MIT
Doc PR NA

When using the new on an entity ExpressionLanguageSyntax (basicaly copy/pasted the sample from https://symfony.com/blog/new-in-symfony-5-1-expressionlanguage-validator), I face a first error:

Constraint validator "" does not exist or is not enabled. Check the "validatedBy" method in your constraint class "Symfony\Component\Validator\Constraints\ExpressionLanguageSyntax".

indeed, the service is need to generate a valide alias

Which looks weird for a Constraint

This PR makes the ExpressionLanguage dependency optionnal in ExpressionLanguageSyntaxValidator, and removes the service than is not needed anyore

@jderusse
Copy link
Member Author

jderusse commented May 20, 2020

ping @Andrej-in-ua

jderusse
jderusse commented May 20, 2020
View reviewed changes
src/Symfony/Component/Validator/Constraints/ExpressionLanguageSyntaxValidator.php Outdated
}
}

private function getExpressionLanguage(): ExpressionLanguage
Copy link
Member Author

@jderusse jderusse May 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspired from

symfony/src/Symfony/Component/Validator/Constraints/ExpressionValidator.php

Lines 53 to 60 in 93248c9

private function getExpressionLanguage(): ExpressionLanguage
{
if (null === $this->expressionLanguage) {
$this->expressionLanguage = new ExpressionLanguage();
}
return $this->expressionLanguage;
}

@xabbuh xabbuh added this to the 5.1 milestone May 21, 2020
@fabpot fabpot changed the base branch from master to 5.1 May 22, 2020 17:13
@fabpot
Copy link
Member

fabpot commented May 22, 2020

Thank you @jderusse.

@fabpot fabpot merged commit 6314732 into symfony:5.1 May 22, 2020
This was referenced May 22, 2020
Closed
Merged
@jderusse jderusse deleted the fix-constraint branch October 15, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

+2 more reviewers

@Andrej-in-ua Andrej-in-ua Andrej-in-ua approved these changes

@Guikingone Guikingone Guikingone left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Status: Reviewed Validator

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

6 participants

@jderusse @fabpot @Andrej-in-ua @Guikingone @xabbuh @carsonbot