[Security] Improved upgrade path for custom remember me services #36832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
force-pushed
the
pr-36806/add-deprecation
branch
from
47f3116 to
2035b08
Compare
src/Symfony/Component/Security/Http/EventListener/RememberMeLogoutListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/EventListener/RememberMeLogoutListener.php
Outdated
Show resolved
Hide resolved
wouterj
force-pushed
the
pr-36806/add-deprecation
branch
from
2035b08 to
c49d00f
Compare
nicolas-grekas
approved these changes
May 16, 2020
chalasr
approved these changes
May 16, 2020
Member
|
Thank you @wouterj. |
Member
|
I'll let you deal with the doc side of this PR, if there is any. |
Member
Author
|
Thanks for the quick merge! For future reference: I don't think docs need to be updated. Implementing a custom remember me service is very unlikely (given that the two implementations of Symfony already have a token provider abstraction layer). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the upgrade path for custom remember me services now
LogoutHandlerInterfacehas been deprecated.As suggested in #36806 (comment), the
logout()method should be added to theRememberMeServicesInterfacein Symfony 6.This patch allows developers to write a custom class implementing only
RememberMeServicesInterfacewith alogout()method. Requiring them to implementLogoutHandlerInterfacewill mean they have to maintain 2 version of the class to support both Symfony 5.1+ and 6.0.