[Form] deprecate not using a rounding mode #36578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Apr 25, 2020
xabbuh
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | yes |
| Tickets | |
| License | MIT |
| Doc PR |
Member
Author
|
I didn't manage to look at #35729 before and did it now. But I think it contains some BC breaks that we need to cover with proper deprecations first which I did here. |
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
What's the current default (before #35729)? Why change it ?
...ymfony/Component/Form/Extension/Core/DataTransformer/PercentToLocalizedStringTransformer.php
Outdated
Show resolved
Hide resolved
Member
Author
|
In 4.4 the transformer will simply not round and act like in this test: https://github.com/symfony/symfony/pull/36578/files#diff-3d096748c112b424e758960eb06177caR40 |
fabpot
approved these changes
May 3, 2020
Member
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.