Skip to content

[Form] apply automatically step=1 for datetime-local input #36523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Apr 23, 2020
Merged

[Form] apply automatically step=1 for datetime-local input #36523

nicolas-grekas merged 1 commit into from
Apr 23, 2020
+39 −0

Conversation

@ottaviano
Copy link
Contributor

@ottaviano ottaviano commented Apr 22, 2020 •
edited
Loading

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets ~
License MIT
Doc PR

this PR just reapplies the same fix from TimeType (#10777 thanks @tucksaun) to DateTimeType.

before:

'widget' => 'single_text',
'with_seconds' => true,

image

after:

'widget' => 'single_text',
'with_seconds' => true,

image

@ottaviano ottaviano requested a review from xabbuh as a code owner April 22, 2020 10:44
@chalasr chalasr added this to the 3.4 milestone Apr 23, 2020
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Apr 23, 2020

Thank you @ottaviano.

@nicolas-grekas nicolas-grekas merged commit ea69f77 into symfony:3.4 Apr 23, 2020
This was referenced Apr 28, 2020
Merged
Merged
Merged
@ottaviano ottaviano deleted the datetime-html5-with-seconds branch April 29, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees

No one assigned

Labels

Bug Form Status: Reviewed

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@ottaviano @nicolas-grekas @chalasr @carsonbot