[Translation] Fix for translation:update command updating ICU messages #36505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Travis build fails on |
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Thanks, here are some remaining minor comments.
src/Symfony/Component/Translation/Tests/MessageCatalogueTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Tests/MessageCatalogueTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Tests/MessageCatalogueTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
bug_36459-translation-update-ignore-inlt-icu
branch
from
284ea74 to
567cee5
Compare
nicolas-grekas
approved these changes
Apr 30, 2020
fabpot
approved these changes
May 3, 2020
Member
|
Thank you @artemoliynyk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
translation:updatecommand executed with option--domain=messages– it ignoremessages-intl-icufile and just create newmessagesMethod
TranslationUpdateCommand::filterCatalogue()onMessageCatalogue::all()method to get all messages for domainBut
MessageCatalogue::all()method disredardintl-icudomains and simply merge all.[Translation] added $strict parameter for MessageCatalogueInterface::all() to be able to get only defined domain messages
[FrameworkBundle] modified translation:update command to respect intl-icu domain