[Notifier] added telegram options #36496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasilnikovs
force-pushed
the
add-telegram-options
branch
from
690b712 to
9405781
Compare
Koc
reviewed
Apr 23, 2020
src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/ReplyKeyboardMarkup.php
Show resolved
Hide resolved
krasilnikovs
force-pushed
the
add-telegram-options
branch
2 times, most recently
from
2629d9a to
8b80798
Compare
flug
reviewed
May 20, 2020
src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/AbstractTelegramReplyMarkup.php
Show resolved
Hide resolved
flug
reviewed
May 20, 2020
| * | ||
| * @see https://core.telegram.org/bots/api#inlinekeyboardbutton | ||
| */ | ||
| class InlineKeyboardButton extends AbstractKeyboardButton |
Contributor
There was a problem hiding this comment.
Suggested change
| class InlineKeyboardButton extends AbstractKeyboardButton | |
| final class InlineKeyboardButton extends AbstractKeyboardButton |
| * | ||
| * @see https://core.telegram.org/bots/api#keyboardbutton | ||
| */ | ||
| class KeyboardButton extends AbstractKeyboardButton |
Contributor
There was a problem hiding this comment.
Suggested change
| class KeyboardButton extends AbstractKeyboardButton | |
| final class KeyboardButton extends AbstractKeyboardButton |
| * | ||
| * @see https://core.telegram.org/bots/api#forcereply | ||
| */ | ||
| class ForceReply extends AbstractTelegramReplyMarkup |
Contributor
There was a problem hiding this comment.
Suggested change
| class ForceReply extends AbstractTelegramReplyMarkup | |
| final class ForceReply extends AbstractTelegramReplyMarkup |
| * | ||
| * @see https://core.telegram.org/bots/api#inlinekeyboardmarkup | ||
| */ | ||
| class InlineKeyboardMarkup extends AbstractTelegramReplyMarkup |
Contributor
There was a problem hiding this comment.
Suggested change
| class InlineKeyboardMarkup extends AbstractTelegramReplyMarkup | |
| final class InlineKeyboardMarkup extends AbstractTelegramReplyMarkup |
src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/Button/AbstractKeyboardButton.php
Show resolved
Hide resolved
| * | ||
| * @see https://core.telegram.org/bots/api#replykeyboardremove | ||
| */ | ||
| class ReplyKeyboardRemove extends AbstractTelegramReplyMarkup |
Contributor
There was a problem hiding this comment.
Suggested change
| class ReplyKeyboardRemove extends AbstractTelegramReplyMarkup | |
| final class ReplyKeyboardRemove extends AbstractTelegramReplyMarkup |
fabpot
requested changes
Aug 6, 2020
Member
fabpot
left a comment
fabpot
left a comment
There was a problem hiding this comment.
LGTM. Anything else needs to be done before merging?
src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/AbstractTelegramReplyMarkup.php
Show resolved
Hide resolved
krasilnikovs
force-pushed
the
add-telegram-options
branch
from
8b80798 to
b4edd0d
Compare
krasilnikovs
force-pushed
the
add-telegram-options
branch
from
b4edd0d to
3ba8d8f
Compare
fabpot
approved these changes
Aug 9, 2020
Member
|
Thank you @krasilnikovm. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added
TelegramOptionsmodel for sending a telegram message with options like the example I have usedSlackOptions.Testing notes:
for testing, I used the scripts
scripts.zip