Skip to content

[Form] validate non-mapped repeated types #36430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xabbuh wants to merge 1 commit into from
Closed

[Form] validate non-mapped repeated types #36430

xabbuh wants to merge 1 commit into from

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 11, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36410
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Apr 11, 2020
@xabbuh xabbuh mentioned this pull request Apr 11, 2020
Merged
@HeahDude
Copy link
Contributor

HeahDude commented Apr 11, 2020

I prefer the other PR that enforces the mapped behavior at the config level.
Here the configuration error is silenced as well but we add complexity/overhead from listeners.

I would merge #36411, and deprecate the behavior in favor of a more robust check in master instead.

@xabbuh
Copy link
Member Author

xabbuh commented Apr 12, 2020

Looking at the issue again I agree with you.

@xabbuh xabbuh closed this Apr 12, 2020
@xabbuh xabbuh deleted the issue-36410 branch April 12, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Form Status: Needs Review

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@xabbuh @HeahDude @carsonbot