[Serializer] Use default context EXCLUDE_FROM_CACHE_KEY for unsetting OBJECT_TO_POPULATE #36363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
… OBJECT_TO_POPULATE
nicolas-grekas
force-pushed
the
serializer-fix-cache-key-unitialized-properties-default-context
branch
from
dd38271 to
8d9a1b6
Compare
Member
|
I think we should reject this PR:
|
Member
|
I agree with @nicolas-grekas, let's close for now. We can still do it in a new PR if it becomes necessary at some point. Thanks for contributing @alanpoulain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #36332, instead of unsetting directly the
OBJECT_TO_POPULATEkey from the context ingetCacheKey, we can add the key to theEXCLUDE_FROM_CACHE_KEYarray of the default context for Symfony >= 4.4.