[Security][Testing] Also allow passing a token to loginUser() #36112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't know how common is to use this "token" instead of a regular user ... but if it's not common enough, I don't think we should support this feature. If you think it's common enough ... I don't think we should change the |
Member
Author
|
Agreed. Let's not make this more complex at first. As there is no typehint (to make the error more user friendly), we can always add this functionality in future releases if there is a need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing the docs, I had the idea to also allow passing a TokenInterface to this login. This also allows to use this method when your application requires a specific token to be present (e.g. a custom token or when you're using instanceof checks).
Meanwhile, I also applied the
get_debug_type()usage introduced in #35945