Skip to content

[Form] Added "collection_entry" block prefix to CollectionType entries #36088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xabbuh merged 1 commit into from
Mar 17, 2020
Merged

[Form] Added "collection_entry" block prefix to CollectionType entries #36088

xabbuh merged 1 commit into from
Mar 17, 2020

Conversation

@HeahDude
Copy link
Contributor

@HeahDude HeahDude commented Mar 15, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #36039
License MIT
Doc PR TODO

Allows to use global collection_entry_row, collection_entry_label, collection_entry_widget and collection_entry_errors themes after dynamic _form_name_collection_name_entry_* ones.

@HeahDude HeahDude requested a review from xabbuh as a code owner March 15, 2020 16:57
@HeahDude HeahDude mentioned this pull request Mar 15, 2020
Closed
@HeahDude HeahDude force-pushed the feat/collection_entry-block_prefix branch 3 times, most recently from 356ddc1 to 400020b Compare March 15, 2020 17:19
yceruto
yceruto requested changes Mar 15, 2020
View reviewed changes
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

@HeahDude HeahDude force-pushed the feat/collection_entry-block_prefix branch from 400020b to fac2149 Compare March 15, 2020 20:29
@HeahDude HeahDude requested a review from yceruto March 15, 2020 20:31
yceruto
yceruto reviewed Mar 15, 2020
View reviewed changes
@HeahDude HeahDude force-pushed the feat/collection_entry-block_prefix branch 3 times, most recently from 45feb67 to 5fbc7ca Compare March 15, 2020 22:02
@fabpot
Copy link
Member

fabpot commented Mar 16, 2020

@javiereguiluz Can you test this one and report?

@javiereguiluz
Copy link
Member

javiereguiluz commented Mar 16, 2020

I've just tested this. I added the changes in CollectionType.php ... but it didn't work for me. I tried adding {% block collection_entry_row %} FOO {% endblock %} and {% block collection_entry_widget %} FOO {% endblock %} in my form theme ... but I don't see any difference. What could I be doing wrong? Thanks.

@HeahDude
Copy link
Contributor Author

HeahDude commented Mar 16, 2020

Thanks for the feedback. That is weird I successfully tried with the Symfony demo app using the fields.html.twig yesterday. Are you sure there is not dynamic _field_name_* template with precedence?

javiereguiluz
javiereguiluz approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this works as expected.

This morning @HeahDude helped me debug the problem ... I copy+pasted the CollectionType changes in the wrong file ... after copying them in the right file, everything is working perfectly!

@xabbuh
Copy link
Member

xabbuh commented Mar 17, 2020

@HeahDude Can you make fabbot happy? :)

@xabbuh xabbuh added this to the next milestone Mar 17, 2020
@HeahDude HeahDude force-pushed the feat/collection_entry-block_prefix branch from 5fbc7ca to 5e459b2 Compare March 17, 2020 09:06
@HeahDude HeahDude force-pushed the feat/collection_entry-block_prefix branch from 5e459b2 to 2ff1f88 Compare March 17, 2020 09:07
@HeahDude
Copy link
Contributor Author

HeahDude commented Mar 17, 2020

@xabbuh done, I've also updated the changelog.

@xabbuh
Copy link
Member

xabbuh commented Mar 17, 2020

Thank you Jules.

@xabbuh xabbuh merged commit c0ee02b into symfony:master Mar 17, 2020
@xabbuh xabbuh mentioned this pull request Mar 17, 2020
Closed
@HeahDude HeahDude deleted the feat/collection_entry-block_prefix branch March 17, 2020 16:10
@HeahDude HeahDude mentioned this pull request Apr 18, 2020
Closed
@javiereguiluz javiereguiluz mentioned this pull request Apr 22, 2020
Closed
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@jbtronics jbtronics mentioned this pull request May 31, 2020
Closed
@majoskorec majoskorec mentioned this pull request Aug 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh xabbuh approved these changes

@yceruto yceruto yceruto approved these changes

Assignees

No one assigned

Labels

Feature Form Status: Reviewed

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

[Form] Allow to customize individual collection items in form themes

7 participants

@HeahDude @fabpot @javiereguiluz @xabbuh @yceruto @nicolas-grekas @carsonbot