Leverage PHP8's get_debug_type() #35945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
requested review from
dunglas,
lyrixx,
sroze and
xabbuh
as code owners
nicolas-grekas
force-pushed
the
get_debug_type
branch
from
ccf394f to
f8552d2
Compare
Member
Author
|
/cc @keradus maybe php-cs-fixer might benefit from a rule here :) |
nicolas-grekas
force-pushed
the
get_debug_type
branch
from
f8552d2 to
36383e4
Compare
nicolas-grekas
force-pushed
the
get_debug_type
branch
from
36383e4 to
b58b70d
Compare
Member
|
hey @nicolas-grekas , (Same time, I must warn you that it will not be the top prio right away on my list, so don't hesitate to help on your own ;) ) |
nicolas-grekas
force-pushed
the
get_debug_type
branch
3 times, most recently
from
1a016ae to
2c3014d
Compare
nicolas-grekas
commented
Mar 3, 2020
fabpot
added a commit
that referenced
this pull request
Mar 4, 2020
…ster (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DI] relax test to ignore changes to error message in master | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Required to make #35945 green (check https://travis-ci.org/symfony/symfony/jobs/657931002#L4720) Commits ------- bf5d25c [DI] relax test to ignore changes to error message in master
nicolas-grekas
force-pushed
the
get_debug_type
branch
from
2c3014d to
a005ca2
Compare
nicolas-grekas
force-pushed
the
get_debug_type
branch
4 times, most recently
from
1626362 to
5a5fb28
Compare
Tobion
reviewed
Mar 15, 2020
Tobion
reviewed
Mar 15, 2020
Member
|
@nicolas-grekas Sorry to inform you that I've ruined your PR... |
nicolas-grekas
force-pushed
the
get_debug_type
branch
from
5a5fb28 to
cc16a14
Compare
nicolas-grekas
force-pushed
the
get_debug_type
branch
4 times, most recently
from
506d368 to
b62961e
Compare
nicolas-grekas
force-pushed
the
get_debug_type
branch
from
b62961e to
daf1c66
Compare
Tobion
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See symfony/polyfill#226 for background.
We might have to port part of the patch to 4.4 when we'll work on having it support PHP 8, but that's not needed for now.