[Routing] Improve localized routes performances #35855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Routing/Tests/Matcher/Dumper/CompiledUrlMatcherDumperTest.php
Outdated
Show resolved
Hide resolved
mtarld
force-pushed
the
feature/localized-route-improvements
branch
from
7d6e446 to
8e9eafe
Compare
nicolas-grekas
approved these changes
Feb 25, 2020
Member
|
Thank you @mtarld. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 2, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [Routing] Fix some wrong localized routes tests | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - ~~Since #35855, the `_locale` path param is directly substituted so those tests are not valid cases anymore. Instead, the path directly contain the right locale.~~ Actually, the compilation is done after, so instead we need to set the new requirement in all tests to reflect the "reality". #35855 also causes a BC break on one case: ```php $compiledUrlGenerator->generate('foo.fr', ['_locale' => 'en'])) ``` Previously, the generated route would be the `/en/fourchette`. Now that the locale is hardcoded in the route path, it will always be `/fr/fourchette`. I changed `foo` to relevant words because it is easier to understand like that. Commits ------- 99ae55f [Routing] Fix some wrong localized routes tests
symfony-splitter
pushed a commit
to symfony/routing
that referenced
this pull request
Mar 2, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [Routing] Fix some wrong localized routes tests | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - ~~Since symfony/symfony#35855, the `_locale` path param is directly substituted so those tests are not valid cases anymore. Instead, the path directly contain the right locale.~~ Actually, the compilation is done after, so instead we need to set the new requirement in all tests to reflect the "reality". symfony/symfony#35855 also causes a BC break on one case: ```php $compiledUrlGenerator->generate('foo.fr', ['_locale' => 'en'])) ``` Previously, the generated route would be the `/en/fourchette`. Now that the locale is hardcoded in the route path, it will always be `/fr/fourchette`. I changed `foo` to relevant words because it is easier to understand like that. Commits ------- 99ae55ff1a [Routing] Fix some wrong localized routes tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the following idea: #35735 (review)
Improve route matching performances by turning dynamic routes with fixed
_localeto actual static routes.