Use strict assertSame instead of assertEquals in Asset component tests #35793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
reviewed
Feb 20, 2020
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
Outdated
Show resolved
Hide resolved
GromNaN
force-pushed
the
fix/3.4/test-style
branch
from
3ec1918 to
7eb776f
Compare
GromNaN
force-pushed
the
fix/3.4/test-style
branch
from
7eb776f to
e8f3e84
Compare
Member
|
Thank you @GromNaN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
assertSameinstead ofassertEqualsis recommended when possible (see sebastianbergmann/phpunit-documentation-english#3). It is stricter and must be more efficient (===vs a comparator class).Also, removing useless string cast.