Skip to content

[DI] Improve the deprecation features by handling package and version #35778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Mar 31, 2020
Merged

[DI] Improve the deprecation features by handling package and version #35778

nicolas-grekas merged 1 commit into from
Mar 31, 2020

Conversation

@atailouloute
Copy link
Contributor

@atailouloute atailouloute commented Feb 18, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? yes
Tickets
License MIT
Doc PR TODO

Improve the deprecation feature of the Dependency Injection component, by handling the package + since_version

Before

services:
    LegacyService:
        deprecated: 'The %service_id% is deprecated, use NewService instead'

now:

services:
    LegacyService:
        deprecated:
            message: 'The %service_id% is deprecated, use NewService instead'
            package: 'my/package'
            since_version: '1.2'

TODO:

  • update UPGRADE

@atailouloute atailouloute force-pushed the improve-di-deprecation branch from 282f202 to 875b04e Compare February 18, 2020 18:06
@nicolas-grekas nicolas-grekas added this to the next milestone Feb 18, 2020
nicolas-grekas
nicolas-grekas reviewed Feb 18, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some food for thoughts :)

@atailouloute atailouloute force-pushed the improve-di-deprecation branch 14 times, most recently from 14e0253 to 1a0de43 Compare February 19, 2020 23:41
nicolas-grekas
nicolas-grekas reviewed Feb 20, 2020
View reviewed changes
@atailouloute atailouloute force-pushed the improve-di-deprecation branch 2 times, most recently from f00b925 to 810d6bf Compare February 20, 2020 10:25
nicolas-grekas
nicolas-grekas reviewed Feb 25, 2020
View reviewed changes
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 25, 2020

(oh, and please mind tests :) )

@atailouloute atailouloute force-pushed the improve-di-deprecation branch 2 times, most recently from 49228e9 to bf80625 Compare February 25, 2020 19:58
@atailouloute atailouloute force-pushed the improve-di-deprecation branch 2 times, most recently from 7e813eb to 9546db7 Compare February 25, 2020 20:48
@atailouloute
Copy link
Contributor Author

atailouloute commented Feb 25, 2020

@nicolas-grekas PR is ready for another review

I did the changes you suggested + I added tests (now all tests with @group legacy are related to the old/deprecated way of using ->setDeprecated, so they will be removed in 6.0)

@atailouloute atailouloute force-pushed the improve-di-deprecation branch from 9546db7 to f98fffa Compare February 25, 2020 20:55
nicolas-grekas
nicolas-grekas reviewed Feb 26, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good, just minor things now.

@atailouloute atailouloute force-pushed the improve-di-deprecation branch 4 times, most recently from 7a2598a to 3d96a97 Compare February 26, 2020 10:49
nicolas-grekas
nicolas-grekas reviewed Feb 26, 2020
View reviewed changes
@nicolas-grekas nicolas-grekas changed the title [DependencyInjection] Improve the deprecation features by handling package and version [DI] Improve the deprecation features by handling package and version Feb 26, 2020
@atailouloute atailouloute force-pushed the improve-di-deprecation branch from 3d96a97 to b736b39 Compare February 26, 2020 11:10
@atailouloute atailouloute force-pushed the improve-di-deprecation branch from b736b39 to 78dfad6 Compare February 26, 2020 13:00
nicolas-grekas
nicolas-grekas reviewed Feb 27, 2020
View reviewed changes
@atailouloute atailouloute force-pushed the improve-di-deprecation branch from 78dfad6 to 3cb1b81 Compare February 27, 2020 12:31
@nicolas-grekas nicolas-grekas force-pushed the improve-di-deprecation branch from 3cb1b81 to f10413c Compare March 31, 2020 19:52
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 31, 2020

Thank you @atailouloute.

@nicolas-grekas nicolas-grekas mentioned this pull request Mar 31, 2020
Closed
@nicolas-grekas nicolas-grekas merged commit c8f4d16 into symfony:master Mar 31, 2020
@nicolas-grekas nicolas-grekas mentioned this pull request Mar 31, 2020
Merged
warslett added a commit to warslett/symfony that referenced this pull request Mar 31, 2020
@warslett
Added new package and version attributes to deprecations introduced in …
bfdbd03 
…symfony#35778
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@dannyvw dannyvw mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof left review comments

@OskarStark OskarStark OskarStark left review comments

+1 more reviewer

@maxhelias maxhelias maxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DependencyInjection Deprecation Feature Status: Reviewed

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

6 participants

@atailouloute @nicolas-grekas @stof @OskarStark @maxhelias @carsonbot