[Routing] Add locale requirement for localized routes #35735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 18, 2020
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
LGTM.
For the future, we could have a smart RouteCompiler that knows how to turn static requirements into actual static routes.
But that's for another PR :)
Tobion
approved these changes
Feb 20, 2020
fabpot
approved these changes
Feb 20, 2020
Member
|
Thank you @mtarld. |
This was referenced Feb 21, 2020
nicolas-grekas
added a commit
that referenced
this pull request
Feb 25, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [Routing] Improve localized routes performances | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | License | MIT Implementation of the following idea: #35735 (review) Improve route matching performances by turning dynamic routes with fixed `_locale` to actual static routes. Commits ------- 8e9eafe [Routing] Improve localized routes performances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.4 version of #35692
If you're using localized routes, you expect to have these kind of routes available:
/fr/accueil/en/homeBut nowadays, these routes are unexpectedly available:
/en/accueil/fr/homeWhen importing routes like that:
prefix: "/{_locale}"@Route({"en": "/home", "fr": "/accueil"}, name="home")This PR proposes to add a strict locale requirement for localized so that the above routes won't be available.