-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Serializer] Serialization versioning #35617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serializer] Serialization versioning #35617
Conversation
|
@ArnaudTarroux Are you still motivated to work on this feature? |
@fabpot Yes I am, I can work on it next week |
8f9ade6 to
b26207d
Compare
nicolas-grekas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me. There is a pending question on the issue: how will one set the current version on real apps?
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractNormalizerTest.php
Outdated
Show resolved
Hide resolved
@nicolas-grekas In the serialization context with the key |
do you think we need a config option to set the default |
0ba9401 to
834c1d9
Compare
Yes maybe in some cases it might be useful. I'll implement it 👍 |
@nicolas-grekas thank for you review. |
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/full.xml
Outdated
Show resolved
Hide resolved
yceruto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency.
src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd
Outdated
Show resolved
Hide resolved
|
We've just moved away from |
Add Serialization versioning.
@Sinceannotation@Untilannotationsinceanduntilto thexmlandyamlmappingversioncontext optionserializer.default_versionin the framework config