Fix HTTP client config handling #35553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
force-pushed
the
fix-undefined-value
branch
from
999e879 to
963d0cc
Compare
Member
|
This LGTM but I'd be happy to have your confirmation @stof please. |
fabpot
approved these changes
Feb 4, 2020
Member
|
Thank you @julienfalque. |
fabpot
added a commit
that referenced
this pull request
Feb 4, 2020
This PR was merged into the 4.4 branch. Discussion ---------- Fix HTTP client config handling | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Defining a `key` parameter in the `query` option of a scoped HTTP client triggers an error: ``` Undefined index: value ``` This PR fixes this issue but an edge case still remains with YAML and PHP config. If one wants to define parameters `key=foo`, `value=bar` and nothing else, the query will actually be `foo=bar` instead of `key=foo&value=bar`. Not sure how to fix this case without breaking the tests I added here. Commits ------- 963d0cc Fix HTTP client config handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining a
keyparameter in thequeryoption of a scoped HTTP client triggers an error:This PR fixes this issue but an edge case still remains with YAML and PHP config. If one wants to define parameters
key=foo,value=barand nothing else, the query will actually befoo=barinstead ofkey=foo&value=bar. Not sure how to fix this case without breaking the tests I added here.