[Messenger] Check for all serialization exceptions during message dec… #35480
+36
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
requested changes
Jan 28, 2020
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Thank you. Just a minor fix and I'll be happy to approve.
src/Symfony/Component/Messenger/Tests/Transport/Serialization/SerializerTest.php
Outdated
Show resolved
Hide resolved
Member
|
Also, make sure that fabbot.io is happy. =) |
Contributor
|
Thank you @waaghals. |
Tobion
added a commit
that referenced
this pull request
Jan 29, 2020
…message dec… (Patrick Berenschot) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Check for all serialization exceptions during message dec… | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35446 | License | MIT Makes it so that the Messenger Serializer throws a `MessageDecodingFailedException` for any serializer exception. Commits ------- 21fffca [Messenger] Check for all serialization exceptions during message dec…
This was referenced Jan 31, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so that the Messenger Serializer throws a
MessageDecodingFailedExceptionfor any serializer exception.