[VarDumper] Add a RdKafka caster #35347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainneutron
force-pushed
the
kafka-caster
branch
from
fc0fb08 to
c40693e
Compare
OskarStark
reviewed
Jan 15, 2020
romainneutron
force-pushed
the
kafka-caster
branch
4 times, most recently
from
37f288b to
c5acb0f
Compare
Member
|
I'm not convinced we should commit the docker-based setup in the VarDumper component. but if we do, it should be excluded from downloads in our I have no knowledge at all about rdkafka so I cannot know whether the caster is correct. |
romainneutron
force-pushed
the
kafka-caster
branch
4 times, most recently
from
7b6a88b to
de433d6
Compare
Member
|
The docker part is not used in the CI. I don't think it's a good idea to add it here. We don't do that for other component |
romainneutron
force-pushed
the
kafka-caster
branch
from
de433d6 to
735d7bb
Compare
Contributor
Author
|
This is WIP code, I'll clean my mess and ask for a review once it's ready :) |
romainneutron
force-pushed
the
kafka-caster
branch
13 times, most recently
from
7f9d905 to
ce59300
Compare
romainneutron
force-pushed
the
kafka-caster
branch
2 times, most recently
from
a25eeb7 to
fe54c8b
Compare
romainneutron
commented
Jan 22, 2020
Contributor
Author
romainneutron
left a comment
romainneutron
left a comment
There was a problem hiding this comment.
My work is now finished, implementation is done, tests are (should be) okay. Comments and review are welcome :)
romainneutron
force-pushed
the
kafka-caster
branch
2 times, most recently
from
c8e5b5e to
7292256
Compare
Contributor
Author
|
PR updated, comments addressed |
src/Symfony/Component/VarDumper/Tests/Caster/RdKafkaCasterTest.php
Outdated
Show resolved
Hide resolved
romainneutron
force-pushed
the
kafka-caster
branch
from
7292256 to
03c4360
Compare
romainneutron
force-pushed
the
kafka-caster
branch
2 times, most recently
from
b455d50 to
1e2ca1e
Compare
Contributor
Author
|
PR updated, comments addressed |
romainneutron
force-pushed
the
kafka-caster
branch
2 times, most recently
from
5227955 to
1681f9b
Compare
lyrixx
changed the title
romainneutron
force-pushed
the
kafka-caster
branch
from
1681f9b to
ab4df87
Compare
Contributor
Author
|
PR updated, comments addressed |
romainneutron
force-pushed
the
kafka-caster
branch
from
ab4df87 to
6cd1235
Compare
Member
|
Thank you @romainneutron. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 4, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [VarDumper] Add a RdKafka caster | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Hello, This is the very beginning of this new feature. First, I'd like to know if there's a no-go for this feature so I won't waste my time. Then, if you are a RdKafka expert, I'd take your comments with much pleasure sincer I'm a noob in this technology (and that's why I'm implementing this caster 🤓) Tests need to be added once the implementation will be a bit more complete. Commits ------- 6cd1235 Add a RdKafka caster to Var-Dumper
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is the very beginning of this new feature.
First, I'd like to know if there's a no-go for this feature so I won't waste my time.
Then, if you are a RdKafka expert, I'd take your comments with much pleasure sincer I'm a noob in this technology (and that's why I'm implementing this caster 🤓)
Tests need to be added once the implementation will be a bit more complete.