[Intl] Fix legacy API #35313
Closed
[Intl] Fix legacy API #35313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Jan 12, 2020
Comment on lines
-50
to
-51
| } catch (MissingResourceException $e) { | ||
| } |
Contributor
Author
There was a problem hiding this comment.
from the issue
// should return
Austrian Germandoes returnGerman
so the fallback already happens, due this catch. This PR doesnt make sense 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy API can crash as of 4.4, due #33148 where we split some indices which affects both the old and new API.
in 4.4 e.g.
[Names][en_US]doesnt exist anymore, hence the $region variable became useless (we force fake a fallback now).The data is still available in
[LocalizedNames][en_US], but let's be pragmatic for now and fix the BC break at least.