Simplify UriSigner when working with HttpFoundation's Request #35284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Failing tests look unrelated. |
fabpot
requested changes
Jan 10, 2020
| * @return string The signed URI | ||
| */ | ||
| public function sign(string $uri) | ||
| public function sign(string $uri): string |
| * @return bool True if the URI is signed correctly, false otherwise | ||
| */ | ||
| public function check(string $uri) | ||
| public function check(string $uri): bool |
Contributor
Author
|
Done. Thought they were missing accidentally during the upgrade to 5.0. |
fabpot
approved these changes
Jan 10, 2020
fabpot
force-pushed
the
simplify-urisigner-check-for-request
branch
from
7363ceb to
4887b4b
Compare
Member
|
Thank you @Toflar. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the
UriSignerin my own projects from time to time and I've always wondered why I have to manually generate the URI from theRequestinstance in such a way that it is correctly validated.Let's add a new
checkRequest(Request $request)method to provide better DX.