[FrameworkBundle] Check non-null type for numeric type #35161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$maxAge and $sharedAge can both be zero
Member
|
Can you add a test case please? |
Member
|
Friendly ping @Arman-Hosseini |
Contributor
Author
|
Sorry. I was busy. I'll definitely do it by the weekend @nicolas-grekas |
fabpot
approved these changes
Feb 3, 2020
Member
|
Thank you @Arman-Hosseini. |
fabpot
added a commit
that referenced
this pull request
Feb 3, 2020
…man-Hosseini) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Check non-null type for numeric type $maxAge and $sharedAge can both be zero | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT Commits ------- 2797867 Check non-null type for numeric type
This was referenced Feb 29, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$maxAge and $sharedAge can both be zero