[TwigBridge] Update bootstrap_4_layout.html.twig missing switch-custom label #34811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested this in a real project - I couldn't find bug. How to reproduce ? |
nvdbeek
approved these changes
Dec 4, 2019
Contributor
Author
|
for a test case: in a FormType ->add(
'categories',
EntityType::class,
[
'label' => false,
'required' => false,
'class' => Category::class,
'expanded' => true,
'multiple' => true,
'label_attr' => ['class' => 'switch-custom']
]
)before after |
bykclk
approved these changes
Dec 4, 2019
bykclk
left a comment
bykclk
left a comment
There was a problem hiding this comment.
Nice job there! I just tested this in a real project - no missing pieces - it works great :).
fabpot
approved these changes
Dec 5, 2019
Missing custom-control-label for custom-switch
Member
|
Thank you @sabruss. |
fabpot
added a commit
that referenced
this pull request
Dec 5, 2019
…witch-custom label (sabruss) This PR was submitted for the master branch but it was merged into the 4.4 branch instead (closes #34811). Discussion ---------- [TwigBridge] Update bootstrap_4_layout.html.twig missing switch-custom label | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | License | MIT Missing .custom-control-label for bootstrap custom-switch when using .switch-custom class in label_attr Commits ------- 9347b2e [TwigBridge] Update bootstrap_4_layout.html.twig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing .custom-control-label for bootstrap custom-switch when using .switch-custom class in label_attr