[FrameworkBundle] Escape percents in ContainerLintCommand #34767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darielopper
approved these changes
Dec 2, 2019
Member
|
Will this work when a value is inlined? Can't we str_replace() on the raw file content instead in the loader, with an flag? |
fancyweb
force-pushed
the
fwb-lint-cmd-escape-parameters
branch
from
601f2ee to
c1749a7
Compare
chalasr
pushed a commit
that referenced
this pull request
Dec 3, 2019
…tainerLintCommand (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Set the parameter bag as resolved in ContainerLintCommand | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34526, Closes #34767 | License | MIT | Doc PR | - Alternative to #34767, idea by @nicolas-grekas. Commits ------- e8d3c2b [FrameworkBundle] Set the parameter bag as resolved in ContainerLintCommand
Member
|
Superseded by #34784. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple alternative to #34541 on the command / read side.
What do you think @nicolas-grekas? It could be a compiler pass but since it's used only for this command, let's keep it simple I guess? Should we find a way to reuse the XmlDumper escaping strategy to always keep the command in sync with it, same question for the "%env(...)%" stuff? This regex is now used 3 times in the code base.