[DoctrineBridge] Fixed DoctrineType::reset to handle IdReaders #34609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darielopper
approved these changes
Nov 25, 2019
nicolas-grekas
approved these changes
Nov 26, 2019
|
|
||
| public function reset() | ||
| { | ||
| $this->idReaders = []; |
Member
There was a problem hiding this comment.
Oh: won't this prevent caching between requests thus reduce perf while it's not needed?
Contributor
Author
There was a problem hiding this comment.
Indeed, the readers are not depending on the request context, nor time sensitive. Closing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #24232, spotted while working on #30994.