Register Singly implemented interfaces through FileLoader #34527
+3
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
fix-directory-loader-2
branch
2 times, most recently
from
002de66 to
9a1b4f0
Compare
simPod
force-pushed
the
fix-directory-loader-2
branch
from
9a1b4f0 to
cb4d80e
Compare
Member
|
I'm missing something: how does this not break the work done in #33350? |
Contributor
Author
|
@nicolas-grekas tests passed so I supposed it did not break it. The main idea here is that registering interfaces should be coupled with |
Member
|
Replaced by #34729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34524
TBH I think this is the correct solution to the problem but not sure how you want to approach it.