Register Singly implemented interfaces through DirectoryLoader #34525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
fix-directory-loader
branch
from
7ce7278 to
83c0884
Compare
simPod
force-pushed
the
fix-directory-loader
branch
from
83c0884 to
3c2f897
Compare
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
The fix LGTM. Could you please add a test case?
| } | ||
| } | ||
|
|
||
| /** {@inheritdoc} */ |
Member
There was a problem hiding this comment.
please use multiple lines for this, to keep consistency with the code base (see the very next method e.g.)
Member
|
Oh, when is this method called at all? |
Contributor
Author
|
This only enables DirectoryLoader to also register interfaces but #34527 is IMO better solution. I'll patch up the demo app so we can talk about something more concrete. |
Member
|
Replaced by #34729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34524
Currently
$interfacesin DirectoryLoader's state are thrown away whenregisterClasses()is called on it.