[Messenger] Perform no deep merging of bus middleware #34347
Merged
+61
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks similar to #32970, on a different node. Looks like a changelog entry would be needed. Please also check the discussion in case it makes sense here too. |
Contributor
Author
|
@nicolas-grekas , added a changelog entry and a test that proves the changes are correct from my POV. |
nicolas-grekas
approved these changes
Nov 17, 2019
fabpot
approved these changes
Nov 17, 2019
fabpot
force-pushed
the
dont-merge-middleware
branch
from
8cad0ec to
c264583
Compare
Member
|
Thank you @vudaltsov. |
fabpot
added a commit
that referenced
this pull request
Nov 17, 2019
…altsov) This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] Perform no deep merging of bus middleware | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a This change helps in case one needs to configure a bus differently for a custom environment while keeping existing handlers attached by name. Commits ------- c264583 [Messenger] Perform no deep merging of bus middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps in case one needs to configure a bus differently for a custom environment while keeping existing handlers attached by name.