[Messenger] WIP: refactoring #34182
Closed
[Messenger] WIP: refactoring #34182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tobion
commented
Oct 30, 2019
Tobion
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #32077 |
| License | MIT |
| Doc PR |
Tobion
commented
Oct 30, 2019
| private $logger; | ||
|
|
||
| /** | ||
| * @param RetryStrategyInterface[] $retryStrategies Retry strategies for each receiver |
Tobion
commented
Oct 30, 2019
| ++$retryCount; | ||
| $delay = $retryStrategy->getWaitingTime($envelope); | ||
| if (null !== $this->logger) { | ||
| $this->logger->error('Error thrown while handling message {class}. Dispatching for retry #{retryCount} using {delay} ms delay. Error: "{error}"', $context + ['retryCount' => $retryCount, 'delay' => $delay, 'error' => $throwable->getMessage(), 'exception' => $throwable]); |
Contributor
Author
There was a problem hiding this comment.
dispatching -> sending
Contributor
Author
|
reopened in #34185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.