Skip to content

[Mailer][MailchimpBridge] Don't send address names if empty string #34034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Oct 22, 2019
Merged

[Mailer][MailchimpBridge] Don't send address names if empty string #34034

fabpot merged 1 commit into from
Oct 22, 2019

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Oct 18, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #34029 (comment)
License MIT
Doc PR N/A

@ogizanagi ogizanagi mentioned this pull request Oct 18, 2019
Merged
@OskarStark
Copy link
Contributor

OskarStark commented Oct 18, 2019

Worth to add a testcase?

@nicolas-grekas nicolas-grekas added this to the next milestone Oct 20, 2019
@fabpot
Copy link
Member

fabpot commented Oct 22, 2019

Thank you @ogizanagi.

fabpot added a commit that referenced this pull request Oct 22, 2019
@fabpot
bug #34034 [Mailer][MailchimpBridge] Don't send address names if empt…
2931227 
…y string (ogizanagi)

This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer][MailchimpBridge] Don't send address names if empty string

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | #34029 (comment) <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

197d123 [Mailer][MailchimpBridge] Don't send address names if empty string
@fabpot fabpot merged commit 197d123 into symfony:4.4 Oct 22, 2019
@ogizanagi ogizanagi deleted the mandrill_from_name branch October 22, 2019 15:53
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees

No one assigned

Labels

Bug Mailer Status: Reviewed

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@ogizanagi @OskarStark @fabpot @nicolas-grekas @carsonbot