[Mailer] Fix attachments and embedded images for Mailchimp API #33996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like your commit email is not associated with your GitHub account ☝🏻 Same for your other PR |
michaelperrin
force-pushed
the
mailer/fix-mandrill-api-attachments
branch
from
46aacba to
d8f544d
Compare
Contributor
Author
|
Thank you @OskarStark for pointing this out! I was sure I did change my author email address, but seems like I didn't… I pushed again with the correct information for this PR. For my other PR, that's too late as @fabpot already merged it, but that's ok as I associated the former email address to my Github account (didn't really want to do that but that's fine). |
michaelperrin
force-pushed
the
mailer/fix-mandrill-api-attachments
branch
from
d8f544d to
064fe24
Compare
Contributor
Author
|
Could this make it for next Symfony 4.3 minor version (along with #33994 which has already been merged)? Thanks :) |
Contributor
Author
|
Closing as #35173 got merged and does the same thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Mandrill transport API payload for embedded images and attachments. Fixes #33995.
As mentioned in #33994, I will make another PR on Wednesday to add some tests on the payload for the 4.4 branch (tests on transports have been introduced for the 4.4 branch) once this gets merged. If you have any better idea, just let me know!