[HttpClient] improve StreamWrapper #33982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
hc-stream
branch
7 times, most recently
from
ebca997 to
ae41b39
Compare
Member
|
no new tests covering what you spotted ? this means we have no way to prevent regressions. |
Member
Author
|
Now with tests. |
nicolas-grekas
force-pushed
the
hc-stream
branch
from
ae41b39 to
ea52d1c
Compare
stof
approved these changes
Oct 15, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Oct 16, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] improve StreamWrapper | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#12389 Spotted while working on the linked doc PR. Commits ------- ea52d1c [HttpClient] improve StreamWrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while working on the linked doc PR.