[HttpClient] add HttpClient::createForBaseUri() #33973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
approved these changes
Oct 13, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Oct 14, 2019
…as-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] add HttpClient::createForBaseUri() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - I've seen ppl use `HttpClient::create()` with default `base_uri` & `auth_bearer`. That's a security risk as the bearer would be sent to any hosts that the client requests. Instead, ppl should use `ScopingHttpClient`. The new method should help to discover and use it. Commits ------- 1aa9a11 [HttpClient] add HttpClient::createForBaseUri()
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen ppl use
HttpClient::create()with defaultbase_uri&auth_bearer. That's a security risk as the bearer would be sent to any hosts that the client requests.Instead, ppl should use
ScopingHttpClient.The new method should help to discover and use it.