Fix BC Compatibility to use old FlattenException in ExceptionController #33918
Conversation
yceruto
left a comment
yceruto
left a comment
There was a problem hiding this comment.
Same opinion as #33916 (review) (:-1:)
The solution will be require symfony/debug as hard dependecy to avoid BC break.
We provide no guarantee at the dependency level: if ppl use Debug but have it transitively, it's accepted policy to require them to make it an explicit dep as of the next version (minor included)
Said another way: the BC policy covers the API, not the deps.
|
@yceruto Sorry this does not work in this case. I change to have symfony/debug as requirement in my library and it is installed but as you see here: Symfony ExceptionListener create a new FlattenException and as that does not extend from the old one. You will get an error that a false FlattenException is given. |
|
I think its a similiar issue we had with the KernelBrowser and the Client here: #31762 which was then later fixed in: #31881 The change in this PR is maybe not correct. Think the only correct fix would be to keep backward compatibility is that a new added class extends the old one and not the other way around. |
|
Want to move this discussion to an issue: #33929 |
4 participants
If you create a CustomExceptionController and typehinted the showAction with the old FlattenException this will break.
Maybe a better solution would to change that the new extend from the old in https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/ErrorRenderer/Exception/FlattenException.php#L381 instead of the old extending the new.