[Serializer] Deprecate the XmlEncoder::TYPE_CASE_ATTRIBUTES constant #33789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Oct 1, 2019
maxhelias
approved these changes
Oct 1, 2019
fabpot
approved these changes
Oct 1, 2019
Member
|
Thank you @pierredup. |
fabpot
added a commit
that referenced
this pull request
Oct 1, 2019
…BUTES constant (pierredup) This PR was merged into the 4.4 branch. Discussion ---------- [Serializer] Deprecate the XmlEncoder::TYPE_CASE_ATTRIBUTES constant | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | yes | Tickets | N/A | License | MIT | Doc PR | N/A | Related | #33788 Deprecate the `XmlEncoder::TYPE_CASE_ATTRIBUTES` constant in favour of `XmlEncoder::TYPE_CAST_ATTRIBUTES` Commits ------- 9f51cf4 Deprecate the XmlEncoder::TYPE_CASE_ATTRIBUTES constant
Member
|
UPGRADE files should have been updated too |
Contributor
Author
|
@nicolas-grekas Done in #33803 |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2019
…TYPE_CASE_ATTRIBUTES constant in upgrade (pierredup) This PR was merged into the 4.4 branch. Discussion ---------- [Serializer] Add note about deprecating the XmlEncoder::TYPE_CASE_ATTRIBUTES constant in upgrade | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | N/A | New feature? | N/A | Deprecations? | N/A | Tickets | #33789 (comment) | License | MIT | Doc PR | N/A Commits ------- b4de582 Add note about deprecating the XmlEncoder::TYPE_CASE_ATTRIBUTES constant in the upgrade guide
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
XmlEncoder::TYPE_CASE_ATTRIBUTESconstant in favour ofXmlEncoder::TYPE_CAST_ATTRIBUTES