[Console] Add deprecation message for non-int statusCode #33775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaedl
force-pushed
the
issue-33747-1
branch
from
0be7fd4 to
67d8227
Compare
fabpot
approved these changes
Sep 30, 2019
Member
|
We need to fix the deprecations in this PR (as tests won't pass). |
nicolas-grekas
requested changes
Oct 1, 2019
Member
|
Don't miss updating the corresponding |
jschaedl
force-pushed
the
issue-33747-1
branch
from
67d8227 to
413683b
Compare
jschaedl
force-pushed
the
issue-33747-1
branch
from
413683b to
78d7da2
Compare
jschaedl
commented
Oct 1, 2019
| * {@inheritdoc} | ||
| */ | ||
| protected function execute(InputInterface $input, OutputInterface $output) | ||
| protected function execute(InputInterface $input, OutputInterface $output): int |
Contributor
Author
There was a problem hiding this comment.
The ContainerDebugCommand is marked as @internal and all subclasses already introduced an int return type-hint for execute(). So I think it is save to add a return type here as well.
jschaedl
force-pushed
the
issue-33747-1
branch
5 times, most recently
from
603ad9e to
3647ef5
Compare
nicolas-grekas
approved these changes
Oct 2, 2019
stof
reviewed
Oct 2, 2019
xabbuh
added a commit
that referenced
this pull request
Oct 2, 2019
…DebugCommand (jschaedl) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Fix wrong returned status code in ConfigDebugCommand | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #33747<!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | - This is a follow-up PR caused by #33775 (comment) Commits ------- 9b5ced2 [FrameworkBundle] Fix wrong returned status code in ConfigDebugCommand
…urning null - added deprecation message for non-int return value in Command::execute() - fixed all core commands to return proper int values - added proper return type-hint to Command::execute() method in all core Commands
nicolas-grekas
force-pushed
the
issue-33747-1
branch
from
3647ef5 to
98c4f6a
Compare
Member
|
Thank you @jschaedl. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2019
…de (jschaedl) This PR was merged into the 4.4 branch. Discussion ---------- [Console] Add deprecation message for non-int statusCode | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #33747 <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | - ### What was done: - [x] added deprecation message for non-int return value in Command::execute() - [x] fixed all core commands to return proper int values - [x] added proper return type-hint to Command::execute() method in all core Commands Commits ------- 98c4f6a [Console] Command::execute() should always return int - deprecate returning null
This was referenced Oct 4, 2019
3 tasks
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done: