[Security] use LegacyEventDispatcherProxy #33693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
force-pushed
the
dispatcher_proxy
branch
from
0441a01 to
efac5bb
Compare
dmaicher
force-pushed
the
dispatcher_proxy
branch
from
efac5bb to
7067e48
Compare
nicolas-grekas
approved these changes
Sep 24, 2019
OskarStark
approved these changes
Sep 24, 2019
javiereguiluz
approved these changes
Sep 25, 2019
maxhelias
approved these changes
Sep 25, 2019
xabbuh
approved these changes
Sep 25, 2019
Member
|
Thank you David. |
xabbuh
added a commit
that referenced
this pull request
Sep 25, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Security] use LegacyEventDispatcherProxy | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - I ran into an issue on one of my apps that has its own event dispatcher class using the old dispatch method signature ```php public function dispatch($eventName, Event $event = null) ``` This leads to ``` TypeError: Argument 2 passed to X\Tests\Base\TestEventDispatcher::dispatch() must be an instance of Symfony\Component\EventDispatcher\Event or null, string given, called in /var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php on line 230 /var/www/x/symfony/tests/Base/TestEventDispatcher.php:20 /var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php:230 /var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php:111 ``` since the event here is dispatched using the new signature: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Security/Http/Firewall/ContextListener.php#L259 Commits ------- 7067e48 [Security] use LegacyEventDispatcherProxy
This was referenced Sep 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue on one of my apps that has its own event dispatcher class using the old dispatch method signature
This leads to
since the event here is dispatched using the new signature:
https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Security/Http/Firewall/ContextListener.php#L259