[DependencyInjection] added Ability to define a priority method for tagged service #33628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Sep 18, 2019
lyrixx
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #32976 |
| License | MIT |
| Doc PR |
lyrixx
force-pushed
the
dic-tagged-prio-meth
branch
from
3f70b43 to
b82dcb5
Compare
src/Symfony/Component/DependencyInjection/Argument/TaggedIteratorArgument.php
Outdated
Show resolved
Hide resolved
lyrixx
force-pushed
the
dic-tagged-prio-meth
branch
from
b82dcb5 to
bf6d037
Compare
Member
Author
|
I added much more tests :D |
stof
reviewed
Sep 19, 2019
src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Fixtures/FooTagClass.php
Outdated
Show resolved
Hide resolved
lyrixx
force-pushed
the
dic-tagged-prio-meth
branch
2 times, most recently
from
d102fa3 to
20b8761
Compare
lyrixx
commented
Sep 23, 2019
src/Symfony/Component/DependencyInjection/Argument/TaggedIteratorArgument.php
Outdated
Show resolved
Hide resolved
stof
reviewed
Sep 24, 2019
src/Symfony/Component/DependencyInjection/Argument/TaggedIteratorArgument.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Argument/TaggedIteratorArgument.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
Outdated
Show resolved
Hide resolved
lyrixx
force-pushed
the
dic-tagged-prio-meth
branch
2 times, most recently
from
db5f9fb to
5dac5c0
Compare
src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
Outdated
Show resolved
Hide resolved
lyrixx
force-pushed
the
dic-tagged-prio-meth
branch
from
5dac5c0 to
792a7ea
Compare
lyrixx
force-pushed
the
dic-tagged-prio-meth
branch
from
792a7ea to
50ead19
Compare
...mfony/Component/DependencyInjection/Tests/Compiler/ResolveTaggedIteratorArgumentPassTest.php
Outdated
Show resolved
Hide resolved
Member
Author
|
No more failures 💚 |
Member
Author
|
@nicolas-grekas Let's merge it? |
stof
approved these changes
Oct 2, 2019
yceruto
approved these changes
Oct 2, 2019
Member
yceruto
left a comment
yceruto
left a comment
There was a problem hiding this comment.
Definitely a needed feature, thank you!
( I left a nitpicking comment :) )
src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
Outdated
Show resolved
Hide resolved
lyrixx
force-pushed
the
dic-tagged-prio-meth
branch
from
50ead19 to
c1917c2
Compare
Member
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2019
…ty method for tagged service (lyrixx) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] added Ability to define a priority method for tagged service | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #32976 | License | MIT | Doc PR | Commits ------- c1917c2 [DependencyInjection] added Ability to define a priority method for tagged service
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.