[DependencyInjection] Fix wrong exception when service is synthetic #33625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
LGTM thank, just a note on the test case.
src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveBindingsPassTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
changed the title
xabbuh
reviewed
Sep 23, 2019
src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveBindingsPassTest.php
Outdated
Show resolved
Hide resolved
Member
|
Thank you @k0d3r1s. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 27, 2019
…synthetic (k0d3r1s) This PR was squashed before being merged into the 3.4 branch (closes #33625). Discussion ---------- [DependencyInjection] Fix wrong exception when service is synthetic | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #32874 | License | MIT This fixes wrongfully thrown exception when service is defined as synthetic and some arguments are binded in _defaults Commits ------- 152dec9 [DependencyInjection] Fix wrong exception when service is synthetic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes wrongfully thrown exception when service is defined as synthetic and some arguments are binded in _defaults